Repository navigation
Bind pseudo-spherical correction arrays - #5
Merged
Merged
Conversation
This commit actions the `spher` flag, so far bound without an actual effect. The associated, required input `radius` (planet radius) and `zd` (atmosphere layer altitudes) are bound. The `zd` array is validated more strictly than what the C code does to avoid degenerate geometries. No default is supplied for `radius`, although a value of 6371 km is suggested in the documentation. Tests validate the output when `spher` is set against the Chapman shell geometry, for which we have an analytical solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR actions the
spherflag, so far bound without an actual effect. The associated, required inputradius(planet radius) andzd(atmosphere layer altitudes) are bound. Thezdarray is validated more strictly than what the C code does to avoid degenerate geometries.No default is supplied for
radius, although a value of 6371 km is suggested in the documentation.Tests validate the output when
spheris set against the Chapman shell geometry, for which we have an analytical solution.