Skip to content

fix: open mime filters by FullPath and close FDs #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
equationzhao wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

fix: open mime filters by FullPath and close FDs #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/filter/itemfliter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,11 @@
if e.IsDir() {
return keep
}
file, err := os.Open(e.Name())
file, err := os.Open(e.FullPath)
if err != nil {
return keep
}
defer file.Close()

Check failure on line 216 in internal/filter/itemfliter.go

View workflow job for this annotation

GitHub Actions / lint 

Error return value of `file.Close` is not checked (errcheck)
mtype, err := mimetype.DetectReader(file)
if err != nil {
return keep
Expand All @@ -234,10 +235,11 @@

func RemoveMimeType(fileTypes ...string) ItemFilterFunc {
return func(e *item.FileInfo) bool {
file, err := os.Open(e.Name())
file, err := os.Open(e.FullPath)
if err != nil {
return keep
}
defer file.Close()

Check failure on line 242 in internal/filter/itemfliter.go

View workflow job for this annotation

GitHub Actions / lint 

Error return value of `file.Close` is not checked (errcheck)
mtype, err := mimetype.DetectReader(file)
if err != nil {
return keep
Expand Down
Loading