Skip to content

Return a 70 error code if the id's in subsonic scrobble are invalid#813

Open
cquike wants to merge 1 commit into
epoupon:masterfrom
cquike:subsonic_scrobble_result_code
Open

Return a 70 error code if the id's in subsonic scrobble are invalid#813
cquike wants to merge 1 commit into
epoupon:masterfrom
cquike:subsonic_scrobble_result_code

Conversation

@cquike

@cquike cquike commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

This PR tries to implement the behaviour described in the OpenSubsonic discussion opensubsonic/open-subsonic-api#201

Maybe it is implemented in a bit of a naive way, specially creating the tack objects might not be necessary to check whether the track id is correct or not.

If any of the id's is invalid, the answer now contains the error 70:

$ curl "https://example.org/rest/scrobble.view?id=tr-999999&id=tr-20000&time=1688760805000&time=1688760805000&submission=True&c=curl&v=1.16.0&f=json&u=user&p=enc:9999999999999999999999999999999999999999999999999999999999999"
{"subsonic-response":{"openSubsonic":true,"serverVersion":"v3.74.0","status":"failed","type":"lms","version":"1.16.1","error":{"code":70,"message":"The requested data was not found."}}}%

@epoupon

epoupon commented Feb 5, 2026

Copy link
Copy Markdown
Owner

Hello! Thanks for the PR 👍
I will fix some issues (like fix build, and more efficient way to check) before submitting

@epoupon epoupon added this to the v3.75.0 milestone Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants