feat(compartment-mapper): support dynamic imports of absolute paths & windows paths - #3338
Open
boneskull wants to merge 1 commit into
Open
feat(compartment-mapper): support dynamic imports of absolute paths & windows paths#3338boneskull wants to merge 1 commit into
boneskull wants to merge 1 commit into
Conversation
… windows paths This adds support for dynamically importing absolute paths (via `import()`) to `@endo/compartment-mapper`. It also adds support for Windows-style paths in both the dynamic `import()` and `require()` use-cases, depending on supplied `ReadPowers`. Added relevant sections to `README.md` and reformatted (fixing headers & the like).
🦋 Changeset detectedLatest commit: 93cad3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
boneskull
added
lavamoat
ecosystem-compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds support for dynamically importing absolute paths (via
import()) to@endo/compartment-mapper.It also adds support for Windows-style paths in both the dynamic
import()andrequire()use-cases, depending on suppliedReadPowers.Added relevant sections to
README.mdand reformatted (fixing headers & the like).Security Considerations
Consumers are encouraged to provide the minimum set of capabilities (
ReadPowers) necessary for desired functionality (though this is nothing new).Scaling Considerations
n/a
Documentation Considerations
Changes (as well as undocumented current behavior) have been documented in
@endo/compartment-mapper'sREADME.md.Testing Considerations
None that I can think of at the moment.
Compatibility Considerations
This is backwards-compatible.
Upgrade Considerations
import()of POSIX absolute paths requires additionalReadPowers(isAbsolute,fileURLToPath).import()or dynamicrequire()of Windows absolute paths requires further additionalReadPowers(pathToFileURL).