Skip to content

Improve Firefox browser process tracking #25644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2025
+3 −3
Merged

Improve Firefox browser process tracking #25644

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea8b331
Improve Firefox browser process tracking by using the -wait-for-brows…
juj Oct 24, 2025
d8680d8
Linux workaround
juj Oct 25, 2025
8fab189
No macOS either
juj Oct 25, 2025
65fa8c8
Fix import
juj Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def configure(data_dir):

class FirefoxConfig:
data_dir_flag = '-profile '
default_flags = ('-new-instance',)
default_flags = ('-new-instance', '-wait-for-browser') if WINDOWS else ('-new-instance',)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably warrants a comment here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll add one. I am still testing to understand why this is necessary.

headless_flags = '-headless'
executable_name = utils.exe_suffix('firefox')

Expand Down Expand Up @@ -2081,13 +2081,13 @@ def launch_browser_harness_with_proc_snapshot_workaround(cls, parallel_harness,
# Give the browser time to spawn its subprocesses. Use an increasing
# timeout as a crude way to account for system load.
if parallel_harness or is_safari():
time.sleep(min(2 + count * 0.3, 10))
time.sleep(min(5 + count * 0.3, 10))
procs_after = list_processes_by_name(config.executable_name)

# Take a snapshot again to find which processes exist after launching
# the browser. Then the newly launched browser processes are determined
# by the delta before->after.
cls.browser_procs = list(set(procs_after).difference(set(procs_before)))
cls.browser_procs += list(set(procs_after).difference(set(procs_before)))
if len(cls.browser_procs) == 0:
exit_with_error('Could not detect the launched browser subprocesses. The test harness will not be able to close the browser after testing is done, so aborting the test run here.')

Expand Down