Skip other.test_pthread_growth test on Windows on ARM #25628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Oct 22, 2025
| if WINDOWS and platform.machine() == 'ARM64': | ||
| # https://github.com/emscripten-core/emscripten/issues/25627 | ||
| # TODO: Switch this to a "require Node.js 24" check | ||
| self.require_node_canary() |
Collaborator
There was a problem hiding this comment.
Should this go in the else block below because the if branch already requires node canary.
Collaborator
Author
There was a problem hiding this comment.
Hmm how do you mean the if branch already requires node canary?
Collaborator
There was a problem hiding this comment.
I mean line 13000 below.
Since the GROWABLE_ARRAYBUFFERS already requires canary, and the comment here belngs instead in the else branch below.
Collaborator
Author
There was a problem hiding this comment.
Right.. I think it probably reads cleaner to not intertwine this test skip/workaround with the growable arraybuffer logic part.
Collaborator
Author
|
Looks like has regressed. (ignored that to land) |
Collaborator
Already reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip other.test_pthread_growth test on Windows on ARM if Node.js is 22.16.0. See #25627
In the future, after #25533 lands, we can move towards a direction of auto-detecting and auto-detecting skipping per Node version.