Run settled before destroy() #1560

NullVoxPopuli · 2025-12-10T20:53:43Z

Situation:

have old code
do things in constructor instead of deriving data "on page load"
switch to @embroider/router
tests can sometimes fail now depending on execution order due to registerBundle being async (with waiters! (good)), but not all tests that call the aforementioned constructor are async, and thus wouldn't be doing anything with settled behavior anyway

Solution:

kategengler · 2025-12-11T04:09:27Z

addon/src/teardown-context.ts

  { waitForSettled = true }: TeardownContextOptions = {},
 ): Promise<void> {
  return Promise.resolve()
+    .then(settled)


when does the argument waitForSettled get passed in as false, and when it does, wouldn't the new await of settled be unexpected?

Run settled beforeDestroy

6adb11e

kategengler reviewed Dec 11, 2025

View reviewed changes

Provide feedback