Skip to content

fixed corroupted checkboxes that contain corroupted characters - #192

Open
rsasuresh wants to merge 1 commit into
masterfrom
fix/pr-template-checkboxes
Open

rsasuresh wants to merge 1 commit into
masterfrom
fix/pr-template-checkboxes

Conversation

@rsasuresh

Copy link
Copy Markdown

Summary

Type of Change

  • eat — New feature
  • ix — Bug fix
  • docs — Documentation only
  • style — Formatting, no code change
  • [ ]
    efactor — Code restructuring without behavior change
  • est — Add or fix tests
  • �uild — Build system or dependency changes
  • ci — CI/CD pipeline changes
  • perf — Performance improvement

Changes

Testing

  • Unit tests pass (ctest --test-dir build --output-on-failure)
  • Integration tests pass
  • Manual testing performed
  • New tests added for new functionality

Pre-Submission Checklist

  • Code compiles without warnings (-Wall -Wextra -Werror for C)
  • All existing tests pass
  • New tests added for new functionality
  • Documentation updated if API changed
  • Commit messages follow (): convention
  • Branch is rebased on latest master

Related Issues

Closing issue

Fixes #

Screenshots / Logs

Additional Notes

@Aswin-V

Aswin-V commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Thanks for catching this, @rsasuresh — the fix is correct: those stray backslashes (\f, \e, \t...) were being read as escape sequences and corrupting the checkbox list, and your PR body above actually demonstrates the bug (note \feat / \fix in the Type of Change section, rendered from the old template).

Three small things before this can land:

  1. Linked-issue policy is failing on this PR (policy / Policy / Linked Issue) — every PR needs a linked issue. Please file one for the template fix (or ask a maintainer to link it).
  2. Typo in the commit message: "corroupted" → "corrupted" (twice). A quick git commit --amend keeps the history clean.
  3. Per repo convention the eventual merge is a maintainer call — leaving that to @Aswin-V / @srpatcha.

Not merging (review-only) — just noting what's needed.

Aswin-V added a commit to embeddedos-org/.github that referenced this pull request Oct 10, 2026
Adds a scope note to the reusable linked-issue-policy workflow: it
grades open pull requests only (requiring a linked same-repository
closing issue) and never grades direct pushes to a default branch — a
red policy check on a PR says nothing about the target branch's health.
Verified 2026-10-10 via embeddedos-org/eos#192, which failed the policy
on the PR while eos master stayed fully green (the author's commit was
on a feature branch, not master, contrary to an earlier misreading).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants