print warning if building embassy-stm32 for bare-metal arm but withou…#6533
Merged
Conversation
…t rt Not activating the `rt` feature will cause all interrupt handlers to be omitted, making anything that relies on interrupts hang/fail/do nothing.
Contributor
Author
|
Thank you for the quick merge. Sadly I discovered that this isn't as useful as I thought it would be: seems like the warnings are only printed in fairly specific circumstances: ref, so users of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t rt
Not activating the
rtfeature will cause all interrupt handlers to be omitted, making anything that relies on interrupts hang/fail/do nothing.I only applied this to
embassy-stm32for now, because I'm not sure if this holds for other HAL crates too.Additionally, I'm not sure whether this should be a warning or just an error: are there use-cases where one wants to do this?
One solution/helpful hand towards resolving #6526