fix(www): cmd+K opening two search modals on the docs site#447
Merged
jrhizor merged 2 commits intoJul 10, 2026
Conversation
RootProvider from fumadocs-ui mounts its own SearchProvider by default,
which registers a cmd+K/ctrl+K listener and renders the default fumadocs
search dialog. The docs layout also mounts the custom SearchDialog via
DocsSidebar, so pressing cmd+K opened both modals stacked on top of each
other. Pass search={{ enabled: false }} so only the custom dialog handles
search.
Also adds my username to contributors.txt to sign the CLA.
Fixes elmohq#443
|
@dchaudhari7177 is attempting to deploy a commit to the Blue Whale Labs Team on Vercel. A member of the Team first needs to authorize it. |
jrhizor
approved these changes
Jul 10, 2026
jrhizor
left a comment
jrhizor
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! Added on a small related change to hide the docs search from the blog pages but looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #443
Problem
Pressing cmd+K / ctrl+K on
/docsopens two stacked search modals.Cause
RootProviderfromfumadocs-uimounts its ownSearchProviderby default, which registers a global cmd+K/ctrl+K keydown listener and lazily renders the default fumadocs search dialog. The docs layout also renders the customSearchDialog(viaDocsSidebar), whoseuseSearchDialoghook registers its own cmd+K listener — so one keystroke opens both dialogs.Fix
Pass
search={{ enabled: false }}toRootProviderindocs-page-layout.tsxso the built-in fumadocs search stays unmounted and only the custom dialog handles cmd+K. Nothing in the repo consumes fumadocs' search context (useSearchContext/SearchOnly/SearchTogglehave no usages), so disabling it has no other effect.Verification
Ran
apps/wwwlocally and dispatched ctrl+K on/docs, counting[role="dialog"]elements:Search— fumadocs default — andSearch docs...— custom)Search docs...), search/navigation still workingtsc --noEmitpasses for@workspace/www.CLA
Added
dchaudhari7177to.github/contributors.txtper CONTRIBUTING.md.