fix(voice): diarizer IFGO cutover — fork reader sync pin + epoch-2 artifact republish (#11377)#11796
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…tifact republish (#11377) The DER-1.000 over-segmentation signature was pure LSTM gate-order skew between diarizer GGUF artifact and reader (proven bit-for-bit in both directions in the rebake-confirm evidence). Cutover, in the safe order: - bump plugins/plugin-local-inference/native/llama.cpp to fork commit dda200ab0 (elizaOS/llama.cpp#40 + #41, both merged): vendored voice_diarizer.c now unpacks gates as IFGO (matching the packages-side converter/reader) and carries the #11569 fail-closed guard — artifacts without converter_epoch>=2 + lstm_gate_order=IFGO are rejected loudly before tensor load instead of silently scrambling. Descendant of the prior pin 58c0391eb, so the #11612 Metal fixes are retained. - add diarizer 0.3.0 to VOICE_MODEL_VERSIONS: new HF file voice/diarizer/pyannote-segmentation-3.0-ifgo-epoch2.gguf (sha 100a5dbf…, HF commit a89e5615, elizaos/eliza-1). The 0.2.0 IOFC artifact stays published for older fused libs. - prefer the epoch-2 filename in the workbench / attribution-smoke probe candidate lists. - evidence: .github/issue-evidence/11377-diarizer-ifgo-cutover/ (DER 1.000 -> 0.211 fixed pairing, loud guard rejection of the published IOFC artifact, kokoro/asr no-regression lanes) + preserve the rebake-confirm bundle referenced from the issue thread. Closes #11377 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
7b63180 to
f53c990
Compare
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Summary
Closes #11377 (diarizer DER 1.000 on the
speakeriso:realbench).The rebake-confirm evidence on the issue proved the DER-1.000 over-segmentation signature is pure LSTM gate-order skew between diarizer GGUF artifact and reader — the fork's vendored fused reader was still IOFC while the packages-side converter/reader moved to IFGO (+ the #11569 fail-closed epoch guard). This PR executes the corrected operator plan in the safe order:
voice_diarizer.c:converter_epoch >= 2andlstm_gate_order == "IFGO"required, epoch-less/IOFC artifacts rejected loudly before tensor load).elizaos/eliza-1as a NEW filevoice/diarizer/pyannote-segmentation-3.0-ifgo-epoch2.gguf(sha100a5dbf…, bit-identical to the rebake-confirm session's deterministic bake; HF commita89e5615). The oldpyannote-segmentation-3.0.gguf(30983eba…) stays published so older fused libs keep working.voice/diarizer/SHA256SUMSadded additively.58c0391eb→dda200ab0(a direct descendant — the On-device local LLM crash-loops on iPhone 16 Pro Max (A18 Pro): NULL Metal pipeline in ggml mul_mat during llama_decode #11612 Metal nil-pipeline/has_bfloat fixes are retained), diarizer0.3.0entry inVOICE_MODEL_VERSIONS, epoch-2 filename preferred in the workbench/attribution-smoke probe lists, evidence bundle.Evidence (all real runs on M4 Max —
.github/issue-evidence/11377-diarizer-ifgo-cutover/)30983ebastale GGUF converter epoch 0; need >= 2 with LSTM gates packed as IFGO→ typedVoiceLifecycleError, bench exit 1 — no silent scrambleomnivoice-test-diarizer-metadata→failures=0(epoch-2 IFGO clears guard to tensor stage; explicit IOFC / epoch-less / epoch-1 rejected with exact messages, stderr-captured)Verification
bun run verify→ exit 0 (full repo, local)packages/sharedvoice-models tests 15/15;plugin-local-inferencevoice-models-routes + voice-model-updater 43/43origin/develop(13f8727) pre-openTest evidence rows
a89e5615(new GGUF + SHA256SUMS), round-trip sha verified.🤖 Generated with Claude Code