Skip to content

chore(local-inference): non-Apple kokoro fast path — gitlink 114eee08e→2bdcef890 (Android/Windows)#11584

Merged
lalalune merged 1 commit into
developfrom
chore/kokoro-nonapple-gitlink
Jul 2, 2026
Merged

chore(local-inference): non-Apple kokoro fast path — gitlink 114eee08e→2bdcef890 (Android/Windows)#11584
lalalune merged 1 commit into
developfrom
chore/kokoro-nonapple-gitlink

Conversation

@lalalune

@lalalune lalalune commented Jul 2, 2026

Copy link
Copy Markdown
Member

Follow-up to #11517. That PR landed the Apple Accelerate kokoro path (submodule 114eee08e); this bumps the gitlink to 2bdcef890 to add the portable non-Apple fast path (Android/Windows) that landed after the merge.

  • Non-Apple branch of the four hot vocoder primitives (Conv1d/ConvTranspose1d/Linear/LSTM gates): internal std::thread pool + NEON vfmaq_f32 on aarch64 (auto-vectorizable scalar on x86). Apple Accelerate path unchanged; pure scalar loop retained as reference.
  • Verified on real arm64: 23/23 parity checks vs scalar (max |Δ| 1.9e-5), NDK r29 cross-compile clean (18 fmla.4s in the aarch64 object), microbench up to 107× on conv1d.
  • Fork: perf(kokoro): Accelerate-BLAS hot loops (417x) + gemma4-assistant MTP converter/runtime llama.cpp#38 (perf/kokoro-accelerate-blas @ 2bdcef890).

Additive submodule bump only — no Milady-side source change. Evidence: .github/issue-evidence/kokoro-metal-perf/.

🤖 Generated with Claude Code

…e non-Apple kokoro fast path

Adds Android/Windows kokoro acceleration on top of the Apple Accelerate path already
on develop (114eee08e). The non-Apple branch of the four hot vocoder primitives
(Conv1d/ConvTranspose1d/Linear/LSTM gates) now uses an internal std::thread pool +
NEON vfmaq_f32 on aarch64 (auto-vectorizable scalar on x86); pure scalar loop retained
as reference. Apple path unchanged.

Verified on real arm64: 23/23 parity checks vs scalar (max |Δ| 1.9e-5), NDK r29
cross-compile clean (18 fmla.4s in aarch64 object), microbench up to 107x on conv1d.
Fork: elizaOS/llama.cpp#38 (perf/kokoro-accelerate-blas @ 2bdcef890).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 73bfa3d6-70e0-42e1-9df2-f4465cc87635

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/kokoro-nonapple-gitlink

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lalalune lalalune merged commit 9426fbf into develop Jul 2, 2026
25 of 29 checks passed
@lalalune lalalune deleted the chore/kokoro-nonapple-gitlink branch July 2, 2026 20:59

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@claude

claude Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant