Apply scaling to virtual monitor reported size#439
Open
flodavid wants to merge 1 commit intoelementary:mainfrom
Open
Apply scaling to virtual monitor reported size#439flodavid wants to merge 1 commit intoelementary:mainfrom
flodavid wants to merge 1 commit intoelementary:mainfrom
Conversation
|
This is related to #436. |
|
If I understood the problem correctly, this issue is more than just rounding up, as the geometry is not handled with logical coordinates while I believe it should. But I may be wrong. |
Author
Yes it is not just rounding up. In added the comment to explain why I added 0.49 |
flodavid
force-pushed
the
fix-multi-monitor-scaling
branch
from
b0741f3 to
20e5a00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where you could not apply a layout where a monitor on the left or on top of another monitor has scaling over 100%, because the configuration would contain gaps and the following error would be raised:
This is because the screen origin is at its top-left. When scaling is applied, the monitor area is smaller, which creates gaps on its right and bottom sides that were not took into account.
This PR resize the monitor area when scaling is modified, logically and visually, so the monitor can be adjacent. Moreover, the user can now see what the real area of the monitor will be.
I did not found an existing issue reporting this, but it could related to #435.