Skip to content

SourceRow: create accent colors for screen#931

Merged
danirabbit merged 4 commits intomasterfrom
danirabbit/sourcerow-styleforscreen
Mar 9, 2026
Merged

SourceRow: create accent colors for screen#931
danirabbit merged 4 commits intomasterfrom
danirabbit/sourcerow-styleforscreen

Conversation

@danirabbit
Copy link
Member

Adding styles to a style context is deprecated and in Gtk4 styles don't propagate to all the children of a style context. So create styles that can be added to the screen and cache them so we don't make duplicates

@danirabbit danirabbit requested a review from a team February 26, 2026 17:27
@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Feb 26, 2026
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little comment :)

@danirabbit danirabbit requested a review from leolost2605 March 9, 2026 17:49
@danirabbit danirabbit merged commit 0dae65c into master Mar 9, 2026
5 of 6 checks passed
@danirabbit danirabbit deleted the danirabbit/sourcerow-styleforscreen branch March 9, 2026 22:10
@github-project-automation github-project-automation bot moved this from Needs Review to Done in GTK4 Porting Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants