Skip to content

VAutoHider: keep a list of children #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danirabbit wants to merge 3 commits into
base: master
Choose a base branch
from
+15 −14
Open

VAutoHider: keep a list of children #930

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6099e80
VAutoHider: keep a list of children
danirabbit Feb 18, 2026
4e8848e
Merge branch 'master' into danirabbit/vautohider-children
danirabbit Feb 18, 2026
5be27cb
Merge branch 'master' into danirabbit/vautohider-children
danirabbit Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions src/Grid/VAutoHider.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,13 @@
*/

public class Maya.View.VAutoHider : Gtk.Bin {
private List<unowned Gtk.Widget> children;
private Gtk.Label more_label;
private Gtk.Box main_box;

construct {
children = new List<unowned Gtk.Widget> ();

more_label = new Gtk.Label ("") {
valign = END
};
Expand All @@ -22,14 +25,10 @@ public class Maya.View.VAutoHider : Gtk.Bin {
}

public override void add (Gtk.Widget widget) {
var children = main_box.get_children ();
children.append (widget);

children.sort (compare_children);

int index = children.index (widget);
main_box.add (widget);
main_box.reorder_child (widget, index);

update (widget);

widget.destroy.connect (() => {
queue_resize ();
Expand All @@ -39,8 +38,6 @@ public class Maya.View.VAutoHider : Gtk.Bin {
}

public void update (Gtk.Widget widget) {
var children = main_box.get_children ();

children.sort (compare_children);

int index = children.index (widget);
Expand All @@ -50,7 +47,7 @@ public class Maya.View.VAutoHider : Gtk.Bin {
public override void size_allocate (Gtk.Allocation allocation) {
base.size_allocate (allocation);
int global_height = allocation.height;
int children_length = (int)main_box.get_children ().length () - 1;
int children_length = (int) children.length ();
if (children_length == 0) {
more_label.hide ();
return;
Expand All @@ -64,9 +61,11 @@ public class Maya.View.VAutoHider : Gtk.Bin {
more_label.get_preferred_height (out more_label_height, null);
more_label.vexpand = true;
more_label.hide ();
foreach (var child in main_box.get_children ()) {
if (child == more_label)

foreach (var child in children) {
if (child == more_label) {
continue;
}

bool last = (shown_children == children_length - 1);

Expand Down Expand Up @@ -97,7 +96,7 @@ public class Maya.View.VAutoHider : Gtk.Bin {
int more = children_length - shown_children;
if (shown_children != children_length && more > 0) {
more_label.show ();
more_label.set_label (_("%u more…").printf ((uint)more));
more_label.label = _("%u more…").printf ((uint) more);
} else {
more_label.hide ();
}
Expand All @@ -106,15 +105,17 @@ public class Maya.View.VAutoHider : Gtk.Bin {
public override void get_preferred_width (out int minimum_width, out int natural_width) {
base.get_preferred_width (out minimum_width, out natural_width);
more_label.get_preferred_width (out minimum_width, null);
if (minimum_width > natural_width)
if (minimum_width > natural_width) {
natural_width = minimum_width;
}
}

public override void get_preferred_height (out int minimum_height, out int natural_height) {
base.get_preferred_height (out minimum_height, out natural_height);
more_label.get_preferred_height (out minimum_height, null);
if (minimum_height > natural_height)
if (minimum_height > natural_height) {
natural_height = minimum_height;
}
}

public static GLib.CompareFunc<weak Gtk.Widget> compare_children = (a, b) => {
Expand Down
Loading