Skip to content

Conversation

@AndrewFerr
Copy link
Member

@AndrewFerr AndrewFerr commented Oct 29, 2025

aka PEP 604, added in Python 3.10

This PR has been broken down into multiple commits, to illustrate the steps used to prepare it.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@AndrewFerr AndrewFerr requested a review from a team as a code owner October 29, 2025 17:48
@github-actions github-actions bot deployed to PR Documentation Preview October 29, 2025 17:49 Active
@github-actions github-actions bot deployed to PR Documentation Preview October 29, 2025 17:51 Active
@AndrewFerr AndrewFerr changed the title Use union type annotations Write union types as X | Y where possible Oct 29, 2025
as `X | Y` is used not only for annotations, but also type aliases
@github-actions github-actions bot deployed to PR Documentation Preview October 29, 2025 17:53 Active
@AndrewFerr
Copy link
Member Author

The trial-olddeps failure is caused by using Pydantic v1, which won't support Python 3.10: pydantic/pydantic#2607 (comment)

Thankfully, there's already a PR for enforcing Pydantic v2: #19071

@github-actions github-actions bot deployed to PR Documentation Preview October 31, 2025 13:38 Active
@AndrewFerr
Copy link
Member Author

The Pydantic update indeed fixed trial-olddeps.

I believe the current Complement test failure (TestPartialStateJoin/joined_members_blocks_during_partial_state_join) is a false-positive, as I recall it sometimes failing in other unrelated PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant