-
Notifications
You must be signed in to change notification settings - Fork 742
feat: allow access to fiddle history #1745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dsanders11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the inline comment, the catch (error) blocks need to be updated to catch (error: any) (or do additional type checking) to make tsc happy.
tests/renderer/components/__snapshots__/settings-general-gist-spec.tsx.snap
Outdated
Show resolved
Hide resolved
f76ce71 to
eb1943f
Compare
eb1943f to
1ec9d4f
Compare
3ed76b1 to
c455e67
Compare
a4ea171 to
d4ffee7
Compare
d4ffee7 to
a590d21
Compare
erickzhao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things to change after checking it out again:
- Can we reverse the list such that the latest revision is the first list we see?
- In the current iteration, I notice that if the Enable History setting is already on in my app, I get a "No Gist ID" error message until I toggle the setting off/on again.
This PR adds the ability to optionally roll back to previous versions of Gists. The option can be enabled and disabled via Settings, and is disabled by default.
Screenshots