Skip to content

Conversation

@erickzhao
Copy link
Member

@erickzhao erickzhao commented Oct 31, 2025

For the last few years, I've been running https://electronjs.org/apps out of my own personal fork of this repository. This PR brings it back into the mainline of the repo.

I did this very naively by deleting all of the contents of electron/apps and pasting erickzhao/apps back into the repo. I might have lost a few apps in the showcase since the forking, but these haven't been shown since the source of truth was from the fork anyways... so I don't expect any regressions there.

Things that I had done on the fork (main...erickzhao:apps:master):

  • Committed 128w images to the git repo.
  • Committed index.json and distributed directly from github.com instead of publishing this repo as an npm package.
  • Removed screenshots.
  • Cleaned stale/broken apps.

Things I did to this PR:

  • Removed colour generation algorithms and dependencies.
  • Minimized other dependencies wherever possible.
  • Fixed GitHub Actions to be pinned to SHAs.
  • Migrated this repo to Yarn v4.
  • Upgraded existing dependencies wherever possible.

@socket-security
Copy link

socket-security bot commented Oct 31, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedhusky@​8.0.1 ⏵ 8.0.3100 +110079 +179100
Addedslugify@​1.6.610010010080100
Updatedyaml@​2.2.2 ⏵ 2.8.1100 +110010081100
Updatedsinon@​14.0.0 ⏵ 21.0.09910098 -286 +1100
Updatedchai@​3.5.0 ⏵ 6.2.0100 +1100100 +487100
Updatedsharp@​0.32.6 ⏵ 0.34.492 -5100100 +188100 +31
Updatedprettier@​2.6.2 ⏵ 3.6.29910010090100
Updatedsemver@​7.5.4 ⏵ 7.7.3100 +1100100 +190100
Updatedmocha@​10.0.0 ⏵ 11.7.497 +110095 +192 -2100
Updatedlint-staged@​12.4.1 ⏵ 12.5.099100100 +195 -1100
Updatedinquirer@​8.2.4 ⏵ 8.2.79910010095100

View full report

@socket-security
Copy link

socket-security bot commented Oct 31, 2025

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Medium
Deprecated by its maintainer: npm @types/minimatch

Reason: This is a stub types definition. minimatch provides its own type definitions, so you do not need this installed.

From: ?npm/[email protected]npm/@types/[email protected]

ℹ Read more on: This package | This alert | What is a deprecated package?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@types/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@erickzhao erickzhao marked this pull request as ready for review November 3, 2025 19:57
@erickzhao erickzhao requested review from a team and Toinane as code owners November 3, 2025 19:57
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of non-blocking comments.

@VerteDinde VerteDinde changed the title chore: unfork + Yarn v4 chore: unfork and Yarn v4 Nov 3, 2025
@VerteDinde VerteDinde changed the title chore: unfork and Yarn v4 chore: unfork + Yarn v4 Nov 3, 2025
@VerteDinde VerteDinde merged commit 07c7189 into electron:main Nov 3, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants