Skip to content

[1.0.50][feat] non-root redux subapp support#1850

Open
gaganjakhotiya wants to merge 1 commit intoelectrode-io:masterfrom
gaganjakhotiya:non-root-redux-subapp
Open

[1.0.50][feat] non-root redux subapp support#1850
gaganjakhotiya wants to merge 1 commit intoelectrode-io:masterfrom
gaganjakhotiya:non-root-redux-subapp

Conversation

@gaganjakhotiya
Copy link

@gaganjakhotiya gaganjakhotiya commented May 15, 2021

This change is to support a similar use-case as loadSubApp does here. If a reduxSubApp needs to be rendered within a composite component we won't be getting the DOM element to render the subapp in.

@CLAassistant
Copy link

CLAassistant commented May 15, 2021

CLA assistant check
All committers have signed the CLA.

@jchip
Copy link
Member

jchip commented Jun 15, 2021

Thanks for the PR. Can you provide some explanation on the context and use case for the change please?

@gaganjakhotiya
Copy link
Author

This is to support a similar use-case as loadSubApp does here. If a reduxSubApp needs to be rendered within a composite component we won't be getting the DOM element to render the subapp in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants