Restructure and group userCRDs values files#2354
Draft
anders-elastisys wants to merge 8 commits intomainfrom
Draft
Restructure and group userCRDs values files#2354anders-elastisys wants to merge 8 commits intomainfrom
anders-elastisys wants to merge 8 commits intomainfrom
Conversation
548d380 to
d9ec80e
Compare
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-changeorkind/dev-changedepending on typeCritical security fixes should be marked with
kind/securityWhat does this PR do / why do we need this PR?
When looking at adding a new "self-managed service", I noticed that the values files that needed to be configured were quite spread out, making it a bit of a hassle to configure. This PR tries to address this somewhat by grouping all values files related to configuring
userCRDsinto one Helmfile values folder.The
user-crdschart was renamed touser-rbac-generatorsince it can be used to create any RBAC not necessarily tied to CRDs. There is also the possibility to configure extra RBAC for Application Developers.This also adds missing values file for
kafkaand fixes the templating for creating theuser-crdsClusterRoleBinding so that it is only created when there are resourceNames specified.Information to reviewers
There might be more improvements we would want to do, like adding a separate Helmfile label for grouping the RBAC and gatekeeper constraints needed for
userCRDs. Also, theuserCRDsname should maybe be changed to e.g.selfManagedServicesor similar, as it is not necessary only related to CRDs, as it involves RBAC as well.Checklist
NetworkPolicy Dashboard