Add acceptance test verifying that agent policies are created in the correct space #1556
+102
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds acceptance testing for agent policies created in non-default Kibana spaces and fixes the import pathway to support space-scoped agent policies. The changes address issue #1553 by ensuring agent policies can be properly imported with their associated space ID.
Key Changes:
- Added acceptance test
TestAccResourceAgentPolicyNonDefaultSpaceverifying agent policy creation and import in non-default spaces - Updated
ImportStatemethod to parse composite IDs containing space and policy IDs - Updated documentation to reflect the new import syntax supporting space-scoped imports
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicyNonDefaultSpace/create/variables.tf | Defines test variables for policy name, space ID, and space name |
| internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicyNonDefaultSpace/create/main.tf | Test configuration creating a Kibana space and agent policy in that space |
| internal/fleet/agent_policy/resource.go | Enhanced ImportState to handle composite IDs with space information |
| internal/fleet/agent_policy/acc_test.go | Added acceptance test verifying agent policy creation and import in non-default spaces |
| examples/resources/elasticstack_fleet_agent_policy/import.sh | Updated import example to show space_id/policy_id format |
| docs/resources/fleet_agent_policy.md | Updated documentation to reflect new import syntax |
| compID, diags := clients.CompositeIdFromStrFw(req.ID) | ||
| if diags.HasError() { | ||
| policyID = req.ID | ||
| } else { |
There was a problem hiding this comment.
The field name ClusterId is misleading in this context as it's being used to store a spaceID, not a cluster ID. Consider using a more appropriate field or adding a comment explaining this usage.
Suggested change
| } else { | |
| } else { | |
| // Note: compID.ClusterId is used here to store the space ID, not a cluster ID. |
dimuon
approved these changes
Dec 16, 2025
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1553
This PR also fixes up the import pathway for agent policies that do not exist in the default space.