Validate space ids meet the API requirements #1555
Merged
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds validation to ensure space IDs conform to the Kibana API requirements before attempting to create or update spaces. The validation provides immediate, specific feedback to users rather than letting them encounter an unhelpful 400 error from the API.
Key Changes:
- Added a
ValidateFuncto the space ID field that enforces lowercase letters, numbers, hyphens, and underscores only
internal/kibana/space.go
Outdated
| Type: schema.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| ValidateFunc: validation.StringMatch(regexp.MustCompile("[a-z0-9_-]+"), "must only contain lowercase letters, numbers, hyphens, and underscores"), |
There was a problem hiding this comment.
The regex is compiled on every validation call. Consider using regexp.MustCompile outside the schema definition or using a pre-compiled pattern to avoid repeated compilation overhead during resource operations.
dimuon
approved these changes
Dec 16, 2025
dimuon
reviewed
Dec 16, 2025
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1553
Without this we get a fairly unhelpful 400 API response, it's a nicer UX providing immediate, and specific feedback.