-
Notifications
You must be signed in to change notification settings - Fork 122
Add ML Datafeed resource #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add ML Datafeed resource #1340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few questions
PlanModifiers: []planmodifier.String{ | ||
stringplanmodifier.UseStateForUnknown(), | ||
}, | ||
Validators: []validator.String{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we were excited to use our fancy new validators we could add a validation for:
This setting is applicable only when the mode is set to manual.
* origin/main: (43 commits) chore(deps): update golang:1.25.3 docker digest to bce1e7e (#1382) Clean before regenerating the client Clean before regenerating the client Use a working API spec chore(deps): update kibana-openapi-spec digest to 9b8ef82 (#1377) Include the generated client in the post upgrade task Reliably run acceptance tests in Kibana client buildkite pipeline (#1378) Test older runner (#1380) Fixup file match chore(deps): update golang docker tag to v1.25.3 (#1369) Add post upgrade tasks for Kibana client Allow free text for Elasticsearch role mapping names (#1373) Use an image with Golang and Terraform Run acceptance tests Remove postUpgradeTasks from renovate chore(deps): pin docker.elastic.co/ci-agent-images/mis-terraform docker tag to 2fae26c (#1371) Synthetics tidy (#1370) Use terraform build image Bump agent resources Don't trigger on PR ...
0d5bdc7
to
15f6b6f
Compare
Requires #1329
Related to #813
Adds a resource to manage the existence of an ML Datafeed. I'm planning on adding an additional resource which manages the state of that data feed (started/stopped) which will close out #813