Skip to content

Conversation

tobio
Copy link
Member

@tobio tobio commented Sep 29, 2025

Requires #1329
Related to #813

Adds a resource to manage the existence of an ML Datafeed. I'm planning on adding an additional resource which manages the state of that data feed (started/stopped) which will close out #813

@tobio tobio requested a review from nick-benoit September 29, 2025 05:30
@tobio tobio self-assigned this Sep 29, 2025
Copy link
Contributor

@nick-benoit nick-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few questions

PlanModifiers: []planmodifier.String{
stringplanmodifier.UseStateForUnknown(),
},
Validators: []validator.String{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we were excited to use our fancy new validators we could add a validation for:

This setting is applicable only when the mode is set to manual.

* origin/main: (43 commits)
  chore(deps): update golang:1.25.3 docker digest to bce1e7e (#1382)
  Clean before regenerating the client
  Clean before regenerating the client
  Use a working API spec
  chore(deps): update kibana-openapi-spec digest to 9b8ef82 (#1377)
  Include the generated client in the post upgrade task
  Reliably run acceptance tests in Kibana client buildkite pipeline (#1378)
  Test older runner (#1380)
  Fixup file match
  chore(deps): update golang docker tag to v1.25.3 (#1369)
  Add post upgrade tasks for Kibana client
  Allow free text for Elasticsearch role mapping names (#1373)
  Use an image with Golang and Terraform
  Run acceptance tests
  Remove postUpgradeTasks from renovate
  chore(deps): pin docker.elastic.co/ci-agent-images/mis-terraform docker tag to 2fae26c (#1371)
  Synthetics tidy (#1370)
  Use terraform build image
  Bump agent resources
  Don't trigger on PR
  ...
@tobio tobio force-pushed the ml-df branch 2 times, most recently from 0d5bdc7 to 15f6b6f Compare October 22, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants