Skip to content

Conversation

@shmsr
Copy link
Member

@shmsr shmsr commented Oct 23, 2025

Proposed commit message

No visual changes. So internally, OpenAI changed the name of their image model to dall-e to unclip-029-dapi and it is reflecting in the older data as well. So specifically in image and audio charts we were using regex filters like dall-e.*, whisper.*, etc. and hence this PR removes those filters so that because of any change in model name or new models, charts render as expected.

This issue was noticed when one of the charts that depended on it did not render although data was there because it was using dall-e.* regex and OpenAI changed the name and that model name isn't even there.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@shmsr shmsr requested a review from a team as a code owner October 23, 2025 20:18
@elasticmachine
Copy link

💚 Build Succeeded

@shmsr shmsr self-assigned this Oct 24, 2025
@ishleenk17
Copy link
Member

hence this PR removes those filters so that because of any change in model name or new models, charts render as expected.

Do we expect it to render other models too incorrectly , since there was a need to add regex initially ?

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shmsr
Copy link
Member Author

shmsr commented Oct 24, 2025

hence this PR removes those filters so that because of any change in model name or new models, charts render as expected.

Do we expect it to render other models too incorrectly , since there was a need to add regex initially ?

Do we expect it to render other models too incorrectly

I checked, it does not. I might have put them as that time there were only one model per image/audio models.

@shmsr shmsr merged commit cbfce60 into elastic:main Oct 24, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package openai - 1.2.1 containing this change is available at https://epr.elastic.co/package/openai/1.2.1/

@andrewkroh andrewkroh added Integration:openai OpenAI dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:openai OpenAI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants