Skip to content

Conversation

@nkvoll
Copy link
Member

@nkvoll nkvoll commented Oct 22, 2025

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@nkvoll nkvoll requested a review from a team as a code owner October 22, 2025 21:26
@kpollich kpollich self-requested a review October 22, 2025 23:11
@kpollich
Copy link
Member

@jsoriano @mrodm Do you think there's a reasonable way for us to hide this integration in Kibana or will that require a code change that excludes this integration from all deployment types? Not sure if we have a flag for internal integrations like this already.

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@jsoriano
Copy link
Member

@jsoriano @mrodm Do you think there's a reasonable way for us to hide this integration in Kibana or will that require a code change that excludes this integration from all deployment types? Not sure if we have a flag for internal integrations like this already.

We don't have any way to hide integrations. While this is kept with a prerelease version at least it won't appear by default.

In any case, maybe it is not so bad to show this integration? There is an official hello-world Docker image 🙂 https://hub.docker.com/_/hello-world/

Maybe we could add a new "Sample" category, that Fleet could use to show this kind of integrations in a different way.

@jsoriano
Copy link
Member

Maybe we could add a new "Sample" category, that Fleet could use to show this kind of integrations in a different way.

Thinking more about this I think this category can be actually useful, issue open to follow up on this elastic/package-spec#1003.

@andrewkroh andrewkroh added New Integration Issue or pull request for creating a new integration package. documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. labels Oct 23, 2025
@kpollich
Copy link
Member

Maybe we could add a new "Sample" category, that Fleet could use to show this kind of integrations in a different way.

Sure having a dedicated category for this type of package is fine with me. Perhaps the risk of having this in the UI is not so high and it'd be easy enough to just include it. If someone wants to deploy an integration that pings https://epr.elastic.co/search and logs the status code of the response then I suppose we could just let them 😁

There are lists in Kibana that allow us to exclude packages from certain deployment types, but I think these result in the packages being excluded from the Kibana APIs as well as the UIs entirely, meaning it will be slightly more difficult to install them. If the package is just available as-is in the the UI and API as "Agentless hello world" under a "Sample" category with a clear description of its intended usage then we're probably fine to just ship it.

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not wait on elastic/package-spec#1003. We can come back and add the sample category to this package later. I vote for merging this as-is since the package is functional and in prerelease anyway. The risk of showing a "sample" package in the general integrations UI is quite low and we should just move forward here. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. New Integration Issue or pull request for creating a new integration package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants