-
Notifications
You must be signed in to change notification settings - Fork 502
feat: add Agentless Hello World integration #15729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
packages/agentless_hello_world/data_stream/generic/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/agentless_hello_world/data_stream/generic/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/agentless_hello_world/data_stream/generic/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
🚀 Benchmarks reportTo see the full report comment with |
…ch/ingest_pipeline/default.yml Co-authored-by: Andrew Kroh <[email protected]>
Co-authored-by: Andrew Kroh <[email protected]>
We don't have any way to hide integrations. While this is kept with a prerelease version at least it won't appear by default. In any case, maybe it is not so bad to show this integration? There is an official hello-world Docker image 🙂 https://hub.docker.com/_/hello-world/ Maybe we could add a new "Sample" category, that Fleet could use to show this kind of integrations in a different way. |
Thinking more about this I think this category can be actually useful, issue open to follow up on this elastic/package-spec#1003. |
Sure having a dedicated category for this type of package is fine with me. Perhaps the risk of having this in the UI is not so high and it'd be easy enough to just include it. If someone wants to deploy an integration that pings https://epr.elastic.co/search and logs the status code of the response then I suppose we could just let them 😁 There are lists in Kibana that allow us to exclude packages from certain deployment types, but I think these result in the packages being excluded from the Kibana APIs as well as the UIs entirely, meaning it will be slightly more difficult to install them. If the package is just available as-is in the the UI and API as "Agentless hello world" under a "Sample" category with a clear description of its intended usage then we're probably fine to just ship it. |
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not wait on elastic/package-spec#1003. We can come back and add the sample category to this package later. I vote for merging this as-is since the package is functional and in prerelease anyway. The risk of showing a "sample" package in the general integrations UI is quite low and we should just move forward here. 🚀
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots