Skip to content

Remove trappy timeouts from ClearInferenceEndpointCacheAction.Request #136796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2025
Merged

Remove trappy timeouts from ClearInferenceEndpointCacheAction.Request #136796

merged 2 commits into from
Oct 20, 2025

Conversation

@DaveCTurner
Copy link
Contributor

This is an internal fire-and-forget action, no sense in imposing any
timeout on the master-node action. It also doesn't care about
acknowledgements so it may as well use a zero ack timeout.

@DaveCTurner
Remove trappy timeouts from ClearInferenceEndpointCacheAction.Request
dbe98bc 
This is an internal fire-and-forget action, no sense in imposing any
timeout on the master-node action. It also doesn't care about
acknowledgements so it may as well use a zero ack timeout.
@DaveCTurner DaveCTurner requested a review from prwhelan October 20, 2025 08:21
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Oct 20, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@DaveCTurner
Copy link
Contributor Author

Probably shouldn't have been an AcknowledgedRequest if you didn't care about acks, but switching it to a plain MasterNodeRequest now is a transport-version change and it doesn't really matter that much.

@DaveCTurner
Copy link
Contributor Author

Also I'm not sure why its equals() and hashcode() implementations look at the ackTimeout() value when this is fixed. Didn't touch that here either.

@DaveCTurner DaveCTurner merged commit 18fb3d9 into elastic:main Oct 20, 2025
34 checks passed
@DaveCTurner DaveCTurner deleted the 2025/10/20/clear-inference-cache-timeouts branch October 20, 2025 13:59
chrisparrinello pushed a commit to chrisparrinello/elasticsearch that referenced this pull request Oct 24, 2025
@DaveCTurner @chrisparrinello
Remove trappy timeouts from `ClearInferenceEndpointCacheAction.Reques…
87f6bea 
…t` (elastic#136796)

This is an internal fire-and-forget action, no sense in imposing any
timeout on the master-node action. It also doesn't care about
acknowledgements so it may as well use a zero ack timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prwhelan prwhelan prwhelan approved these changes

Assignees

No one assigned

Labels

:ml Machine learning >non-issue Team:ML Meta label for the ML team v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DaveCTurner @elasticsearchmachine @prwhelan