Migrate ILM REST tests to new test framework. #136744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to ES-11813
mosche
added
>test
elasticsearchmachine
added
v9.3.0
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mosche
added
auto-backport
mark-vieira
approved these changes
Oct 21, 2025
| } | ||
|
|
||
| tasks.named("check").configure { dependsOn 'follow-cluster' } | ||
| if (buildParams.inFipsJvm) { |
There was a problem hiding this comment.
We have a utility for this:
tasks.named("javaRestTest") {
buildParams.withFipsEnabledOnly(it)
}
| public static TemporaryFolder repoDir = new TemporaryFolder(); | ||
|
|
||
| public static ElasticsearchCluster leaderCluster = ElasticsearchCluster.local() | ||
| .module("x-pack-ilm") |
There was a problem hiding this comment.
For multi-cluster tests it's generally good practice to give them unique names. The default is "test-cluster" but you can use name() to customize this. This can be helpful when analyzing the logs, since the node nodes use the cluster name as a prefix. That way you can see leader-1 and follower-1 in the test output vs just test-cluster-n and have to figure out which cluster it is.
| @ClassRule | ||
| public static ElasticsearchCluster cluster = ElasticsearchCluster.local() | ||
| .module("x-pack-ilm") | ||
| .setting("xpack.ml.enabled", "false") |
There was a problem hiding this comment.
Is this setting still necessary if we aren't including the ML module?
mosche
added
the
auto-merge-without-approval
💔 Backport failed
You can use sqren/backport to manually backport by running |
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Oct 24, 2025
I'll follow up consolidating the projects in another PR. This felt easier to review if migrating in place. Relates to ES-11813 (cherry picked from commit 440faee) # Conflicts: # x-pack/plugin/ilm/qa/multi-cluster/src/javaRestTest/java/org/elasticsearch/xpack/ilm/CCRIndexLifecycleIT.java # x-pack/plugin/ilm/qa/multi-node/build.gradle # x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/actions/SearchableSnapshotActionIT.java
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Oct 24, 2025
I'll follow up consolidating the projects in another PR. This felt easier to review if migrating in place. Relates to ES-11813 (cherry picked from commit 440faee) # Conflicts: # x-pack/plugin/ilm/qa/multi-cluster/build.gradle # x-pack/plugin/ilm/qa/multi-cluster/src/javaRestTest/java/org/elasticsearch/xpack/ilm/CCRIndexLifecycleIT.java # x-pack/plugin/ilm/qa/multi-node/build.gradle # x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/actions/SearchableSnapshotActionIT.java # x-pack/plugin/ilm/qa/rest/build.gradle # x-pack/plugin/ilm/qa/with-security/build.gradle
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Oct 24, 2025
I'll follow up consolidating the projects in another PR. This felt easier to review if migrating in place. Relates to ES-11813 (cherry picked from commit 440faee) # Conflicts: # x-pack/plugin/ilm/qa/multi-cluster/src/javaRestTest/java/org/elasticsearch/xpack/ilm/CCRIndexLifecycleIT.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 24, 2025
* Migrate ILM REST tests to new test framework. (#136744) I'll follow up consolidating the projects in another PR. This felt easier to review if migrating in place. Relates to ES-11813 (cherry picked from commit 440faee) # Conflicts: # x-pack/plugin/ilm/qa/multi-cluster/src/javaRestTest/java/org/elasticsearch/xpack/ilm/CCRIndexLifecycleIT.java # x-pack/plugin/ilm/qa/multi-node/build.gradle # x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/actions/SearchableSnapshotActionIT.java * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 24, 2025
* Migrate ILM REST tests to new test framework. (#136744) I'll follow up consolidating the projects in another PR. This felt easier to review if migrating in place. Relates to ES-11813 (cherry picked from commit 440faee) # Conflicts: # x-pack/plugin/ilm/qa/multi-cluster/build.gradle # x-pack/plugin/ilm/qa/multi-cluster/src/javaRestTest/java/org/elasticsearch/xpack/ilm/CCRIndexLifecycleIT.java # x-pack/plugin/ilm/qa/multi-node/build.gradle # x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/actions/SearchableSnapshotActionIT.java # x-pack/plugin/ilm/qa/rest/build.gradle # x-pack/plugin/ilm/qa/with-security/build.gradle * [CI] Auto commit changes from spotless * fix --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 24, 2025
* Migrate ILM REST tests to new test framework. (#136744) I'll follow up consolidating the projects in another PR. This felt easier to review if migrating in place. Relates to ES-11813 (cherry picked from commit 440faee) # Conflicts: # x-pack/plugin/ilm/qa/multi-cluster/src/javaRestTest/java/org/elasticsearch/xpack/ilm/CCRIndexLifecycleIT.java * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll follow up consolidating the projects in another PR. This felt easier to review if migrating in place.
Relates to ES-11813