-
Notifications
You must be signed in to change notification settings - Fork 115
Add specification for ESQL Views CRUD #5836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds support for (get|put|delete)-view APIs to the specification Relates to elastic/elasticsearch#137818
|
@pquentin I'm sure I probably made a mistake somewhere for this, please let me know what needs to be fixed! |
|
Following you can find the validation changes against the target branch for the APIs.
You can validate these APIs yourself by using the |
| "name": "esql.delete_view", | ||
| "privileges": { | ||
| "cluster": [ | ||
| "monitor_esql" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be replaced by the real privileges once they exist: delete_view, manage_view
pquentin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. Unfortunately we can't use YAML tests to validate net-new APIs, but once this is merged we'll have results and will be able to iterate.
This adds support for (get|put|delete)-view APIs to the specification
Relates to elastic/elasticsearch#137818