Add support for chat_completion task in Azure OpenAI integration #5796
Conversation
Jan-Kazlouski-elastic
added
ml
skip-backport
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
…mpletion-integration
…mpletion-integration # Conflicts: # output/openapi/elasticsearch-openapi.json # output/openapi/elasticsearch-serverless-openapi.json # output/schema/schema.json # specification/inference/put/PutRequest.ts
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@redocly/cli": "^1.34.5" | ||
| "@redocly/cli": "^1.34.6" |
There was a problem hiding this comment.
I assume this change wasn't intentional, but we probably shouldn't be updating dependencies as part of adding docs for the inference API.
There was a problem hiding this comment.
This is done by make setup & make contrib execution. It is mandatory to execute that before merging.
There was a problem hiding this comment.
Changing it to ^1.34.5 results in it going back to ^1.34.6 as soon as make setup is called
| */ | ||
| user?: string | ||
| } | ||
|
|
There was a problem hiding this comment.
On line 819 above this, "For a `completion` or `text_embedding` task" should be "For a `completion`, `chat_completion` or `text_embedding` task"
There was a problem hiding this comment.
Good catch. Fixed.
| * * Anthropic (`completion`) | ||
| * * Azure AI Studio (`completion`, `rerank`, `text_embedding`) | ||
| * * Azure OpenAI (`completion`, `text_embedding`) | ||
| * * Azure OpenAI (`completion`, `chat_completion`, `text_embedding`) |
There was a problem hiding this comment.
Nitpick, but could these be in alphabetical order like for the other providers?
There was a problem hiding this comment.
Done.
| "type": "enum", | ||
| "description": "The task type", | ||
| "options": ["completion", "text_embedding"] | ||
| "options": ["completion", "chat_completion", "text_embedding"] |
There was a problem hiding this comment.
Nitpick, but could these be in alphabetical order?
There was a problem hiding this comment.
Done.
…mpletion-integration
…tting description
|
Hi @DonalEvans |
2 participants
This PR adds changes to specification caused by elastic/elasticsearch#138726
Additional actions