Replace multi_json and oj gems with standard Ruby json gem#2992
Open
larouxn wants to merge 1 commit into
Open
Conversation
|
💚 CLA has been signed |
larouxn
force-pushed
the
farewell_multi_json
branch
from
8b60fef to
8158b11
Compare
|
This would be nice for another reason: currently, elasticsearch-ruby emits |
larouxn
force-pushed
the
farewell_multi_json
branch
from
8158b11 to
f1e2762
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposing we remove the
multi_jsonandojgems in favour of the standard Rubyjsongem as it's now as fast or faster in the majority of cases compared tooj. Additionally allows us to simplify code quite a bit too. ✨Related efforts
jsongem for 4.0.0-beta.5 opensearch-project/opensearch-ruby#290ojand its initializer and addjsonto the Gemfile mastodon/mastodon#37752Implementation
More or less just a swap and cleanup. Nothing of particular note stands out.