fix(ci): create GitHub release after npm publish - #3394
Open
margaretjgu wants to merge 2 commits into
Open
Conversation
JoshMock
reviewed
Jul 31, 2026
JoshMock
left a comment
JoshMock
left a comment
Member
There was a problem hiding this comment.
The GH release creation step was removed now that we have an upstream "create release" workflow in the team repo that should trigger this downstream npm publish. If it does need to be reinstated, can we add a condition that it only runs when this workflow was triggered by a workflow_dispatch?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish workflow was missing the GitHub release creation step. Adds it after npm publish, using the ephemeral vault token. Also bumps
contentspermission fromreadtowritewhich is required to create releases.