Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Oct 23, 2025

What does this PR do?

Remove secrets from pre-command
Use BK plugins

Why is it important?

explicitness versus obfuscation

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

In the CI

DRA_VERSION="9.3.0"
DRA_WORKFLOW="snapshot"
MANIFEST_URL="https://snapshots.elastic.co/9.3.0-d90d0809/agent-package/agent-artifacts-9.3.0-SNAPSHOT.json"
DRA_DRY_RUN="--dry-run"
DRA_VERSION="9.3.0"
DRA_WORKFLOW="staging"
MANIFEST_URL="https://snapshots.elastic.co/9.3.0-d90d0809/agent-package/agent-artifacts-9.3.0-SNAPSHOT.json"
DRA_DRY_RUN="--dry-run"

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

explicitness versus obfuscation
@v1v v1v self-assigned this Oct 23, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2025

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@v1v v1v added skip-changelog backport-9.2 Automated backport to the 9.2 branch labels Oct 23, 2025
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 23, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @v1v

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/no-more-precommand-for-secrets-used-by-dra upstream/feature/no-more-precommand-for-secrets-used-by-dra
git merge upstream/main
git push upstream feature/no-more-precommand-for-secrets-used-by-dra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-9.2 Automated backport to the 9.2 branch skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants