Skip to content

Conversation

@fr4nc1sc0-r4m0n
Copy link
Contributor

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n commented Oct 22, 2025

What does this PR do?

This PR aims to remove the resources cleanup process form the elastic-platform-ingest gcp account and its dependency with the secret kv/ci-shared/observability-ingest/cloud/gcp because no resource is being created there.
All of the CI resources are currently created in the elastic-observability-ci account.

Why is it important?

Removing dependency with a deprecated secret and on useless cleanup process

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

This pull request does not have a backport label. Could you fix it @fr4nc1sc0-r4m0n? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you delete .buildkite/misc/gce-cleanup.yml?

@fr4nc1sc0-r4m0n
Copy link
Contributor Author

can you delete .buildkite/misc/gce-cleanup.yml?

Forgot it! Thanks

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n marked this pull request as draft October 22, 2025 14:31
@ycombinator
Copy link
Contributor

This PR aims to remove the resources cleanup process form the elastic-platform-ingest aws account

I think you mean the GCP account?

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 22, 2025

💔 Build Failed

Failed CI Steps

History

cc @fr4nc1sc0-r4m0n

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n changed the title Remove resources cleanup elastic-platform-ingest aws account Remove resources cleanup elastic-platform-ingest gcp account Oct 22, 2025
@fr4nc1sc0-r4m0n
Copy link
Contributor Author

I think you mean the GCP account?

Absolutely! Fixed
Thanks @ycombinator

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants