-
Notifications
You must be signed in to change notification settings - Fork 612
[Rule Tuning] PowerShell Rules - Misc Tuning/Severity Bumps #5486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
|
⛔️ Test failed Results
|
| | where not ( | ||
| file.directory == "C:\\ProgramData\\Microsoft\\Windows Defender Advanced Threat Protection\\Downloads" or | ||
| file.directory like "C:\\\\ProgramData\\\\Microsoft\\\\Windows Defender Advanced Threat Protection\\\\DataCollection*" | ||
| file.directory like ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should double check that this is not minstacked to a specific version (e.g. 9.1.0). It's hard to tell in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the PR tags, it is 8.19 and up: elastic/elasticsearch#129170
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| user.id | ||
| // Filter for scripts that match the pattern at least 10 times | ||
| | where Esql.script_block_pattern_count >= 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see many FPs with current count, any reason to bump it up ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not noisy, but from what I saw, there was like 1 TP below 20, and 110 FPs
| _version, | ||
| _index, | ||
| host.name, | ||
| agent.id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see some execution error on some clusters like:
line 25:5: Unknown column [agent.id], did you mean any of [user.id, event.code]? [siem.esqlRule][Potential PowerShell Obfuscation via Invalid Escape Sequences][rule id f7a7edb5-1e5c-40a5-a67d-b1e895dce521][rule uuid 64f17c52-6c6e-479e-ba72-236f3df18f3d][exec id ae4ac43d-0d33-4d1c-9437-62284c3d4fa2][space default]
maybe agent.id is not always defined in Windows integration ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be, anything collected with using Elastic Agent has a agent.id (AFAIK)
rules/windows/defense_evasion_posh_obfuscation_backtick_var.toml
Outdated
Show resolved
Hide resolved
rules/windows/defense_evasion_posh_obfuscation_char_arrays.toml
Outdated
Show resolved
Hide resolved
rules/windows/defense_evasion_posh_obfuscation_concat_dynamic.toml
Outdated
Show resolved
Hide resolved
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
Issues
Part of BAU maintenance https://github.com/elastic/ia-trade-team/issues/619
Summary
Adjust thresholds to reduce noise, bumps the severity of non-noisy rules.