Skip to content

Exclude dev and test deps from docker images#431

Merged
seanstory merged 2 commits into
mainfrom
fix/exclude-dev-test-gems-from-docker
Apr 16, 2026
Merged

Exclude dev and test deps from docker images#431
seanstory merged 2 commits into
mainfrom
fix/exclude-dev-test-gems-from-docker

Conversation

@seanstory

Copy link
Copy Markdown
Member

Part of #430

Looks like we're not correctly stripping out our dev/test dependencies at build time.

After merging this, we probably need to cut a new release.

Checklists

Pre-Review Checklist

  • This PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check crawler.yml.example and elasticsearch.yml.example)
  • This PR has a meaningful title
  • This PR links to all relevant GitHub issues that it fixes or partially addresses
    • If there is no GitHub issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v0.1.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference
  • Ran make notice if any dependencies have been added

Release Note

Fixes a packaging bug that was causing CVE scanners to flag false positives on Open Crawler

@seanstory

Copy link
Copy Markdown
Member Author

@mattnowzari can you take a look?

@artem-shelkovnikov

Copy link
Copy Markdown
Member

How's the image size difference after this change?

@seanstory

Copy link
Copy Markdown
Member Author

50MB → 339MB — a 111MB reduction (~25%) on the production wolfi image just by excluding dev/test gems

@seanstory seanstory merged commit d148862 into main Apr 16, 2026
2 checks passed
@seanstory seanstory deleted the fix/exclude-dev-test-gems-from-docker branch April 16, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants