fix(sharepoint_online): recover from stale drive deltas and sync content via Graph - #4370
Draft
Jan-Kazlouski-elastic wants to merge 2 commits into
Draft
fix(sharepoint_online): recover from stale drive deltas and sync content via Graph#4370Jan-Kazlouski-elastic wants to merge 2 commits into
Jan-Kazlouski-elastic wants to merge 2 commits into
Conversation
… paths Recover incremental sync when drive delta tokens expire (410 Gone), fetch list attachments and site pages via Microsoft Graph instead of SharePoint REST, and warn when DLS is enabled with client-secret auth. Part of elastic/sdh-search#1940
- Recover from 410 Gone on any drive delta request (full sync, incremental, and mid-pagination) with a single restart from root/delta - Fetch site page details (canvasLayout, sharepointIds) via Graph for content and stable SharePoint list item ids for DLS REST compatibility - Use stable attachment document ids from list/item/attachment graph ids - Add clear_drive_delta_link helper and expanded unit tests Part of elastic/sdh-search#1940
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/elastic/sdh-search/issues/1940
Fixes SharePoint Online sync failures for tenants using client-secret auth with DLS disabled, as reported in the SDH above.
410 Goneon any delta request (full sync, incremental, and mid-pagination) with a single restart fromroot/deltaper driveUnauthorizedwith app-only credentials)canvasLayout,sharepointIds) for body content and stable SharePoint list item idsvalidate_configwhen DLS is enabled with client-secret auth (REST permissions path limitation)Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)Changes Requiring Extra Attention
Related Pull Requests
SharePointHomeCacheList(already in 8.19.20)Release Note
SharePoint Online connector now recovers automatically from expired drive delta links (
410 Gone) and fetches site pages and list attachments via Microsoft Graph, improving sync reliability for app-only authentication.