Project history UI #652
Open
Project history UI #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wendong-Fan
reviewed
Nov 14, 2025
Comment on lines
+123
to
+127
| # Count completed and failed tasks (assuming status 1 = completed, others = failed/ongoing) | ||
| if history.status == 1: # ChatStatus.done | ||
| project_data['total_completed_tasks'] += 1 | ||
| else: # Not ongoing, assume failed | ||
| project_data['total_failed_tasks'] += 1 |
Contributor
There was a problem hiding this comment.
we shouldn't assume others are also count as failed
Comment on lines
+60
to
+66
| case 3: // Failed | ||
| return ( | ||
| <Tag variant="cuation" size="sm"> | ||
| <XCircle /> | ||
| <span>{t("layout.failed")}</span> | ||
| </Tag> | ||
| ); |
Contributor
There was a problem hiding this comment.
I think we haven't defined case 3 in ChatStatus
Contributor
|
enhance PR: #656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@a7m-1st While testing the new feature, I found this bug — it might be related to something I accidentally changed. Could you please help me look into it?
Also, I added a new component: ProjectDialog.tsx in GroupedHistoryView.
The dialog includes a feature that allows users to edit the project name. However, the updated task name isn’t being saved or sent to be stored. I believe the API endpoint for updating the project name may need to be adjusted — could you take a look at that as well?
What is the purpose of this pull request?