Skip to content

feat: add Truthiness datatype for Monte Carlo comparisons #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add Truthiness datatype for Monte Carlo comparisons #128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dcdf4c
feat: add Truthiness datatype for Monte Carlo comparisons
wdconinc Oct 29, 2025
b397bf9
CamelCase 🐪🐫🐫🐫🐫🐫🐫🐫 (starting with dromedary)
wdconinc Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion edm4eic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,13 @@ components:
- bool TOTInProgress // Flag which indicates if TOT calculation is ongoing, ADC value may be corrupted if this is true
- bool TOTComplete // Flag which indicates if a TOT calculation is complete and TOT value is valid

## Event-level truthiness information
edm4eic::TruthinessContribution:
Members:
- float pid // Contribution of PID matching to truthiness
- float energy // Contribution of energy matching to truthiness
- float momentum // Contribution of momentum matching to truthiness

datatypes:

edm4eic::Tensor:
Expand Down Expand Up @@ -540,7 +547,7 @@ datatypes:
- edm4eic::ReconstructedParticle hadrons // Reconstructed hadrons used in calculation

## ==========================================================================
## Data-Montecarlo relations
## Data-Monte Carlo relations
## ==========================================================================

edm4eic::MCRecoParticleAssociation:
Expand Down Expand Up @@ -623,6 +630,27 @@ datatypes:
- edm4eic::Track from // reference to the track
- edm4eic::ProtoCluster to // reference to the protocluster

## ==========================================================================
## Data-Monte Carlo comparisons
## ==========================================================================

edm4eic::Truthiness:
Description: "Positive-definite convex norm of how confidently wrong the reconstruction is,
with non-negative contributions from various aspects of the reconstruction,
where a zero value indicates a perfect reconstruction."
Author: "W. Deconinck, S. Colbert"
Members:
- float truthiness // Overall truthiness of the entire event
- edm4eic::TruthinessContribution associationContribution // Contribution from all associated particles
- float unassociatedMCParticlesContribution // Contribution from unassociated MC particles
- float unassociatedRecoParticlesContribution // Contribution from unassociated reconstructed particles
VectorMembers:
- edm4eic::TruthinessContribution associationContributions // Contribution from associated particles
OneToManyRelations:
- edm4eic::MCRecoParticleAssociation associations // Reference to the associated particles
- edm4hep::MCParticle unassociatedMCParticles // Reference to the unassociated MC particles
- edm4eic::ReconstructedParticle unassociatedRecoParticles // Reference to the unassociated reconstructed particles

Copy link
Contributor Author

@wdconinc wdconinc Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definition of the truthiness data type excludes vertex terms. I don't think at this point we are ready to compare generated and reconstructed vertices, and they are not easily accessible through individual associations. It may be possible to have some adhoc relation to a MCParticle mean the vertex where that particle was generated. Still, I think that is a harder problem than this first attempt. One thing to keep in mind in the vertexing problem is that it is hard to define what a missing reconstructed vertex should be since some vertices are going to be so close together as to be effectively unresolvable.

links:
edm4eic::TrackProtoClusterLink:
Description: "Link between a ProtoCluster and a Track"
Expand Down