Don't fail if child isn't present#19
Open
gussmith23 wants to merge 1 commit intoegraphs-good:mainfrom
Open
Conversation
Member
|
I am not sure about supporting visualizations of incomplete/malformed egraphs… I do think it might be better just to panic here instead of silently ignoring an edge. In egglog, we do omit some nodes sometimes to keep the sizes down and we either replace them with a dummy node or remove the edges as well. Were you removing them for visualization purposes to help debug something? Or was it for performance? |
Author
|
Sorry for slow response. Yes -- i was trying to visualize the egraph during debugging, but pruning to just the interesting nodes. Do you have a better suggestion for doing this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am currently manually pruning out irrelevant nodes from my serialized egraph. The
unwrapI removed was causing errors when encountering removed children.I can also add a warning in an
elsebranch, if desired.