Open
Conversation
Signed-off-by: Khaled Emara <mail@KhaledEmara.dev>
Signed-off-by: Khaled Emara <mail@KhaledEmara.dev>
Signed-off-by: Khaled Emara <mail@KhaledEmara.dev>
Signed-off-by: Khaled Emara <mail@KhaledEmara.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
MIME Type Detection
I replaced the filetype package with the mimetype package because it's faster and more accurate.
Logs
I categorized all debug logs as so and included one INFO log for each ICAP request including all the needed fields.
Each field is its own JSON key. I prefixed ICAP headers with
icap_headerand HTTP Headers withhttp_headerfor readability and searchability in the ELK stack.I tried querying in Kibana and I can filter by anything I want: Virus Name, Request Type, and anything I want.