Add options to configure size & records of ingest batches.#59
Open
mosche wants to merge 1 commit into
Open
Conversation
Author
|
@samuel-pt @springml Would appreciate your 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've recently run into the ingest record limit (10k). Unfortunately there's no work around due to the repartitioning done here.
This PR adds two configuration options to better control ingest batches:
batchSize: (Optional) The size in bytes per ingest batch. Default value is10 MB, maximum size is10 MB.batchRecords: (Optional) The number of records per ingest batch. Per default onlybatchSizeis considered. Maximum number of records per batch is10,000.Both are optional and if not set, the behavior remains as is: ingest batches will be up to an estimated 10 MB large despite the number of records.