Skip to content

Fix Chromatic configuration drift and Storybook caching - #7

Merged
effinrich merged 2 commits into
chromatic-fixfrom
effinrich-chromatic-nx-fix
Sep 23, 2026
Merged

effinrich merged 2 commits into
chromatic-fixfrom
effinrich-chromatic-nx-fix

Conversation

@effinrich

Copy link
Copy Markdown
Owner

Summary

  • consolidate local and CI Chromatic execution on the root configuration
  • remove unsupported GitHub Action inputs and stale package-local configs
  • enable Turbo caching for deterministic Storybook builds

Verification

  • bun run build-storybook --filter=@richtillman/ui
  • consecutive scoped build reuses the Turbo cache
  • workflow YAML and Chromatic/Turbo JSON parse successfully

This is intentionally stacked on chromatic-fix because it follows up on that branch's Chromatic pipeline changes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 23, 2026 18:14
@chromatic-com

chromatic-com Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Tip

All tests passed and all changes approved!

🟢 UI Tests: 38 visual and accessibility changes accepted as baselines
🟢 UI Review: Approved by Rich Tillman
Storybook icon Storybook Publish: 79 stories published

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Only a minor non-blocking style nit remains.

Review effort: Lite
Findings: None

What changed in this PR

Consolidates Chromatic configuration at the repository root and enables Turbo caching for Storybook builds.

Changes:

  • Centralizes Chromatic settings and CI execution.
  • Removes stale package-local configuration.
  • Enables caching for Storybook builds.
File Description
turbo.json Enables Storybook build caching.
packages/​ui/​turbo.json Removes obsolete package-level configuration.
packages/​ui/​README.md Documents shared Chromatic configuration; contains a minor semicolon style nit.
packages/​ui/​chromatic.config.json Removes stale package-local configuration.
chromatic.config.json Uses the package’s chromatic-build script.
.github/​workflows/​chromatic.yml Uses the shared root Chromatic configuration.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@effinrich
effinrich added this pull request to stack #8 September 23, 2026 18:25
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@effinrich

Copy link
Copy Markdown
Owner Author

Reviewed in Chromatic: build 45 passes with all 38 changes human-approved and zero accessibility violations. These replace build 43's capture-timeout failures, so no additional code fix is needed.

@effinrich
effinrich merged commit 36ec3bc into main Sep 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants