Update GeoLite Database #47
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GeoLite database update workflow to target the 'release-ulmo' branch instead of 'master', reflecting a change in the deployment branching strategy. The changes include updating default branches, improving branch naming, enhancing shell script robustness with proper quoting, changing the review assignment from an individual to a team, and updating the GitHub token to support team reviewer assignments.
Key Changes:
- Updated default and target branch from 'master' to 'release-ulmo' for consistency with current deployment strategy
- Changed branch naming to use
github.run_idinstead ofgithub.shafor more predictable unique identifiers - Updated authentication token from
github.tokentosecrets.GH_PAT_WITH_ORGto support team reviewer assignments
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --base 'master' \ | ||
| --reviewer 'feanil' \ | ||
| --head "$BRANCH" \ | ||
| --base 'release-ulmo' \ |
There was a problem hiding this comment.
The branch input parameter is defined for workflow_dispatch but is never used. The base branch for PR creation is hardcoded to 'release-ulmo' on line 82 instead of using ${{ inputs.branch }}. This makes the workflow_dispatch input ineffective.
Consider changing line 82 to use the input parameter:
--base '${{ inputs.branch || 'release-ulmo' }}'This would allow manual workflow runs to specify a different target branch while defaulting to 'release-ulmo' for scheduled runs.
PR generated by workflow on behalf of @ktyagiapphelix2u.