Skip to content

fix: update geolite workflow #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktyagiapphelix2u merged 6 commits into from
Dec 9, 2025
Merged

fix: update geolite workflow #40

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c73c01b
fix: update geolite workflow
ktyagiapphelix2u Nov 19, 2025
0842fac
fix: update geolite workflow
ktyagiapphelix2u Nov 21, 2025
a292683
fix: Update branch naming convention for PR creation
ktyagiapphelix2u Nov 21, 2025
d6c741f
fix: variable usage in update-geolite-database
ktyagiapphelix2u Nov 21, 2025
3501dfa
fix: branch creation command in workflow
ktyagiapphelix2u Nov 21, 2025
248d96c
fix: branch naming convention for GeoIP updates
ktyagiapphelix2u Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/update-geolite-database.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
branch:
description: "Target branch against which to create PR"
required: false
default: "master"
default: "release-ulmo"
Comment on lines 8 to +11
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch input parameter is defined but never used in the workflow. The checkout step doesn't use inputs.branch to determine which branch to check out, and the PR base is now hardcoded to 'release-ulmo'.

Consider either:

  1. Removing the unused branch input parameter if it's no longer needed, or
  2. Using it to dynamically set the checkout ref and PR base branch like: ref: "${{ inputs.branch || 'release-ulmo' }}" in the checkout step and --base '${{ inputs.branch || 'release-ulmo' }}' in the PR creation command.

Copilot uses AI. Check for mistakes.

env:
MAXMIND_URL: "https://download.maxmind.com/app/geoip_download?edition_id=GeoLite2-Country&license_key=${{ secrets.MAXMIND_LICENSE_KEY }}&suffix=tar.gz"
Expand Down Expand Up @@ -79,13 +79,13 @@ jobs:
--title "Update GeoLite Database" \
--body "PR generated by workflow `${{ github.workflow }}` on behalf of @${{ github.actor }}." \
--head $BRANCH \
--base 'master' \
--reviewer 'feanil' \
--base 'release-ulmo' \
--reviewer 'edx/orbi-bom' \
| grep -o 'https://github.com/.*/pull/[0-9]*')
echo "PR Created: ${PR_URL}"
echo "pull-request-url=$PR_URL" >> $GITHUB_OUTPUT
env:
GH_TOKEN: ${{ github.token }}
GH_TOKEN: ${{ secrets.GH_PAT_WITH_ORG }}

- name: Job summary
run: |
Expand Down
Loading