Skip to content

fix: adding new script to run the jenkin job#313

Open
ktyagiapphelix2u wants to merge 3 commits intomasterfrom
ktyagi/archiver
Open

fix: adding new script to run the jenkin job#313
ktyagiapphelix2u wants to merge 3 commits intomasterfrom
ktyagi/archiver

Conversation

@ktyagiapphelix2u
Copy link
Contributor

@ktyagiapphelix2u ktyagiapphelix2u commented Feb 4, 2026

Description

Adds a new Jenkins utility shell script for creating job-scoped Python virtual environments using Python’s built-in venv module (intended to improve compatibility with Python 3.12+).

Related PR

edx/jenkins-job-dsl#1827

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Jenkins utility shell script for creating job-scoped Python virtual environments using Python’s built-in venv module (intended to improve compatibility with Python 3.12+).

Changes:

  • Introduces util/jenkins/virtualenv_python_tools.sh with create_virtualenv_python to create venvs under $JOBVENVDIR.
  • Adds basic argument parsing for --python=... and --clear.
  • Automatically upgrades pip/setuptools/wheel after venv creation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 4, 2026 07:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 4, 2026 08:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (6)

playbooks/roles/testcourses/tasks/main.yml:36

  • Previously this used include: deploy.yml tags=deploy, which applies the deploy tag to all tasks inside deploy.yml. include_tasks does not accept the tags= include-parameter; if you still need included tasks to be selectable via --tags deploy, use apply: { tags: [deploy] } (or switch to import_tasks if a static include is acceptable).
- include_tasks: deploy.yml
  tags:
    - deploy

playbooks/roles/hotg/tasks/main.yml:144

  • Previously this was include: deploy.yml tags=deploy, which tags the tasks inside deploy.yml. With include_tasks, ensure the included tasks still receive the deploy tag (e.g., via apply: { tags: [deploy] }, or use import_tasks if appropriate) so tag-scoped runs behave the same.
- include_tasks: deploy.yml
  tags:
    - deploy

playbooks/create_rds.yml:88

  • Indentation here places include_tasks at the play level rather than under the tasks: list. As written, this makes the playbook YAML structure invalid (or at least not part of the play’s tasks). It should be indented to the same level as the other tasks under tasks:.
- include_tasks: create_db_and_users.yml
  when: database_connection.login_host is defined

playbooks/roles/gitreload/tasks/main.yml:87

  • Previously this was include: deploy.yml tags=deploy, which tags tasks inside deploy.yml. With include_tasks, preserve that behavior using apply tags (or import_tasks) so --tags deploy runs still execute the included tasks.
- include_tasks: deploy.yml
  tags:
    - deploy

playbooks/roles/demo/tasks/main.yml:43

  • Previously this was include: deploy.yml tags=deploy, which tags tasks inside deploy.yml. With include_tasks, use apply: { tags: [deploy] } (or import_tasks) if you need tag-filtered runs to behave identically.
- include_tasks: deploy.yml
  tags:
    - deploy

playbooks/roles/edxapp/tasks/deploy.yml:521

  • This include used to be include: tag_ec2.yml tags=deploy but now the include task is tagged remove/aws and no longer applies the deploy tag to the tasks inside tag_ec2.yml. Since tag_ec2.yml doesn’t define its own tags, this changes behavior for --tags deploy runs (and may cause it to run only under remove). Consider restoring deploy tagging via apply: { tags: [deploy] } and/or adjusting the include task’s tags: to match the previous intent.
- include_tasks: tag_ec2.yml
  when: COMMON_TAG_EC2_INSTANCE
  tags:
    - remove
    - aws

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 4, 2026 08:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have one comment that I think needs to be addressed before merging, and another you can consider as a suggestion.

@timmc-edx
Copy link
Member

Failing checks aren't relevant to this PR, feel free to ignore them. I've filed https://2u-internal.atlassian.net/browse/BOMS-408 to look into it.

Copilot AI review requested due to automatic review settings February 6, 2026 07:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@robrap
Copy link
Contributor

robrap commented Feb 6, 2026

@ktyagiapphelix2u: As a reminder, before reaching out to Tim for a re-review, ensure all copilot PR comments in the Conversation view of this PR have been handled, starting from the top. Also, please ensure that tests are all green. assuming there isn't a reason to make an exception. Thank you.

@ktyagiapphelix2u
Copy link
Contributor Author

@robrap I’ve resolved all the comments, and the failures were unrelated to my changes, so Tim approved the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants