fix: adding new script to run the jenkin job#313
fix: adding new script to run the jenkin job#313ktyagiapphelix2u wants to merge 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Jenkins utility shell script for creating job-scoped Python virtual environments using Python’s built-in venv module (intended to improve compatibility with Python 3.12+).
Changes:
- Introduces
util/jenkins/virtualenv_python_tools.shwithcreate_virtualenv_pythonto create venvs under$JOBVENVDIR. - Adds basic argument parsing for
--python=...and--clear. - Automatically upgrades
pip/setuptools/wheelafter venv creation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (6)
playbooks/roles/testcourses/tasks/main.yml:36
- Previously this used
include: deploy.yml tags=deploy, which applies thedeploytag to all tasks inside deploy.yml.include_tasksdoes not accept thetags=include-parameter; if you still need included tasks to be selectable via--tags deploy, useapply: { tags: [deploy] }(or switch toimport_tasksif a static include is acceptable).
- include_tasks: deploy.yml
tags:
- deploy
playbooks/roles/hotg/tasks/main.yml:144
- Previously this was
include: deploy.yml tags=deploy, which tags the tasks inside deploy.yml. Withinclude_tasks, ensure the included tasks still receive thedeploytag (e.g., viaapply: { tags: [deploy] }, or useimport_tasksif appropriate) so tag-scoped runs behave the same.
- include_tasks: deploy.yml
tags:
- deploy
playbooks/create_rds.yml:88
- Indentation here places
include_tasksat the play level rather than under thetasks:list. As written, this makes the playbook YAML structure invalid (or at least not part of the play’s tasks). It should be indented to the same level as the other tasks undertasks:.
- include_tasks: create_db_and_users.yml
when: database_connection.login_host is defined
playbooks/roles/gitreload/tasks/main.yml:87
- Previously this was
include: deploy.yml tags=deploy, which tags tasks inside deploy.yml. Withinclude_tasks, preserve that behavior usingapplytags (orimport_tasks) so--tags deployruns still execute the included tasks.
- include_tasks: deploy.yml
tags:
- deploy
playbooks/roles/demo/tasks/main.yml:43
- Previously this was
include: deploy.yml tags=deploy, which tags tasks inside deploy.yml. Withinclude_tasks, useapply: { tags: [deploy] }(orimport_tasks) if you need tag-filtered runs to behave identically.
- include_tasks: deploy.yml
tags:
- deploy
playbooks/roles/edxapp/tasks/deploy.yml:521
- This include used to be
include: tag_ec2.yml tags=deploybut now the include task is taggedremove/awsand no longer applies thedeploytag to the tasks inside tag_ec2.yml. Since tag_ec2.yml doesn’t define its own tags, this changes behavior for--tags deployruns (and may cause it to run only underremove). Consider restoringdeploytagging viaapply: { tags: [deploy] }and/or adjusting the include task’stags:to match the previous intent.
- include_tasks: tag_ec2.yml
when: COMMON_TAG_EC2_INSTANCE
tags:
- remove
- aws
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
640365b to
41a3a8c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timmc-edx
left a comment
There was a problem hiding this comment.
Looks good! I have one comment that I think needs to be addressed before merging, and another you can consider as a suggestion.
|
Failing checks aren't relevant to this PR, feel free to ignore them. I've filed https://2u-internal.atlassian.net/browse/BOMS-408 to look into it. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@ktyagiapphelix2u: As a reminder, before reaching out to Tim for a re-review, ensure all copilot PR comments in the Conversation view of this PR have been handled, starting from the top. Also, please ensure that tests are all green. assuming there isn't a reason to make an exception. Thank you. |
|
@robrap I’ve resolved all the comments, and the failures were unrelated to my changes, so Tim approved the PR. |
Description
Adds a new Jenkins utility shell script for creating job-scoped Python virtual environments using Python’s built-in venv module (intended to improve compatibility with Python 3.12+).
Related PR
edx/jenkins-job-dsl#1827