refactor: BOMS-200 contract features dict settings into top level settings#258
Merged
Akanshu-2u merged 1 commit intomasterfrom Sep 25, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the configuration structure by removing the nested FEATURES dictionary and promoting its settings to top-level configuration variables across edxapp deployment files.
- Removes the
EDXAPP_FEATURES_DEFAULTandEDXAPP_FEATURESdictionary definitions from main.yml - Eliminates the
FEATURESdictionary wrapper in studio.yml and lms.yml while preserving all feature settings - Promotes all feature flags to top-level configuration settings for better accessibility
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| playbooks/roles/edxapp/defaults/main.yml | Removes FEATURES dict definitions and references while keeping individual feature variables |
| docker/build/edxapp/studio.yml | Removes FEATURES wrapper and duplicate feature settings, keeping top-level feature flags |
| docker/build/edxapp/lms.yml | Removes FEATURES wrapper and duplicate feature settings, keeping top-level feature flags |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vaibhavgulati02
approved these changes
Sep 25, 2025
jcapphelix
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR approaches the contraction of the
FEATURESdict to enable top level settings.Solution:
Contracted
FEATURESdict within:Related PRs
JIRA Ticket:
BOMS-200