FDB-593 add wipe unit tests. #199
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #199 +/- ##
===========================================
+ Coverage 72.62% 72.72% +0.10%
===========================================
Files 360 361 +1
Lines 21705 21924 +219
Branches 2244 2255 +11
===========================================
+ Hits 15764 15945 +181
- Misses 5941 5979 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tests/fdb/api/test_wipe.cc
Outdated
| using namespace eckit; | ||
|
|
||
| namespace { | ||
| void deldir(eckit::PathName& p) { |
There was a problem hiding this comment.
I'm sure I've seen this functionality elsewhere before. Is there not a helper function we should be using?
| namespace test { | ||
|
|
||
| CASE("Setup") { | ||
|
|
There was a problem hiding this comment.
This doesn't look right.
Test cases should be self contained (using an object as a fixture if needed).
|
|
||
| char data[] = "test"; | ||
|
|
||
| SECTION("WIPE MULTIPLE DATABASES; DRY-RUN WIPE") { |
There was a problem hiding this comment.
don't know why the label is in all-caps
There was a problem hiding this comment.
This is sometimes helpful to quickly see where the output for a given section starts or ends in the middle of long and cluttered test outputs.
tests/fdb/api/test_wipe.cc
Outdated
| // wipe one database | ||
| fdb5::WipeElement elem; | ||
| auto wipeObject = fdb.wipe(dbReq1, true); | ||
| while (wipeObject.next(elem)) |
There was a problem hiding this comment.
Always put {} for if and while if the contents are on a separate line.
There was a problem hiding this comment.
Manually fixed for now, but a discussion is taking place separately to potentially add this into clang-format.
tests/fdb/api/test_wipe.cc
Outdated
| // FDB configurations to test | ||
|
|
||
| std::string localSingleRootConfig{ | ||
| "spaces:\n" |
There was a problem hiding this comment.
Use C++ multi-line strings.
Description
Adds wipe unit tests.
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-199
🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-199