releng: update features for new dependencies, move new product, feature to staging#386
Merged
MatthewKhouzam merged 1 commit intoeclipse-tracecompass:masterfrom Apr 8, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (18)
✅ Files skipped from review due to trivial changes (17)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughPatch-level release/releng updates: many test/core modules have bundle and Maven version bumps; a new RCP product and P2 feature descriptor (v11.3.0.qualifier) are added; target definitions gain Felix Gogo/OSGi service units and an ECF p2 repository entry. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@rcp/org.eclipse.tracecompass.rcp/staging/feature.xml`:
- Around line 56-58: The feature.xml contains a duplicate plugin declaration for
id "org.eclipse.swtchart" with version="0.0.0"; remove the redundant plugin
element (the second occurrence) so only a single <plugin
id="org.eclipse.swtchart" version="0.0.0"/> remains in the feature definition,
and verify no other duplicate plugin entries exist elsewhere in the file.
In `@releng/org.eclipse.tracecompass.target/tracecompass-e4.39.target`:
- Line 1: The target file tracecompass-e4.39.target declares
name="tracecompass-eStaging", duplicating tracecompass-eStaging.target; to fix,
open the tracecompass-e4.39.target file and either change the target element's
name attribute from "tracecompass-eStaging" to "tracecompass-e4.39" so the
filename and internal name match, or delete this file if it is an unnecessary
duplicate of tracecompass-eStaging.target; ensure the resulting target names
follow the existing pattern (e.g., name="tracecompass-e4.39") before committing.
In `@releng/org.eclipse.tracecompass.target/tracecompass-eStaging.target`:
- Around line 110-116: The configured ECF p2 repository URL in the <repository
location="https://download.eclipse.org/rt/ecf/3.16.2/site.p2/"/> entry is
missing P2 metadata (artifacts.jar/content.jar/site.xml) and will cause target
resolution to fail; locate the correct ECF p2 repository that contains valid P2
metadata for version 3.16.2 (or update to a reachable release repository), then
replace the location attribute value in the tracecompass-eStaging.target
<repository> element so the InstallableUnit entries (e.g.,
org.eclipse.ecf.core.feature.feature.group,
org.eclipse.ecf.filetransfer.feature.feature.group,
org.eclipse.ecf.filetransfer.httpclient5.feature.feature.group,
org.eclipse.ecf.filetransfer.httpclientjava.feature.feature.group) point to a
repository that returns artifacts.jar/content.jar/site.xml. Ensure the updated
URL is accessible and contains P2 metadata before committing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4164d9bf-4807-417f-957b-7651af42f15e
📒 Files selected for processing (20)
analysis/org.eclipse.tracecompass.analysis.timing.core.tests/META-INF/MANIFEST.MFanalysis/org.eclipse.tracecompass.analysis.timing.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.timing.core/META-INF/MANIFEST.MFcommon/org.eclipse.tracecompass.common.core.tests/META-INF/MANIFEST.MFcommon/org.eclipse.tracecompass.common.core.tests/pom.xmlctf/org.eclipse.tracecompass.ctf.core.tests/META-INF/MANIFEST.MFctf/org.eclipse.tracecompass.ctf.core.tests/pom.xmlctf/org.eclipse.tracecompass.tmf.ctf.core/META-INF/MANIFEST.MFctf/org.eclipse.tracecompass.tmf.ctf.ui.swtbot.tests/META-INF/MANIFEST.MFctf/org.eclipse.tracecompass.tmf.ctf.ui.swtbot.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.kernel.core/META-INF/MANIFEST.MFlttng/org.eclipse.tracecompass.lttng2.ust.core/META-INF/MANIFEST.MFrcp/org.eclipse.tracecompass.rcp.product/staging/tracing.productrcp/org.eclipse.tracecompass.rcp.product/tracing.productrcp/org.eclipse.tracecompass.rcp/feature.xmlrcp/org.eclipse.tracecompass.rcp/staging/feature.xmlreleng/org.eclipse.tracecompass.integration.core.tests/META-INF/MANIFEST.MFreleng/org.eclipse.tracecompass.integration.core.tests/pom.xmlreleng/org.eclipse.tracecompass.target/tracecompass-e4.39.targetreleng/org.eclipse.tracecompass.target/tracecompass-eStaging.target
arfio
force-pushed
the
releng-update-features
branch
from
7662787 to
7f1c3d3
Compare
…re to staging Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
arfio
force-pushed
the
releng-update-features
branch
from
7f1c3d3 to
323a168
Compare
Contributor
Author
|
@jonahgraham Can you please review this change? |
jonahgraham
reviewed
Apr 8, 2026
jonahgraham
approved these changes
Apr 8, 2026
Contributor
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
Approved - but I am not a committer on the project and I may not have enough background. Your change seems fine and in line with how version bumps were done previously as well.
MatthewKhouzam
approved these changes
Apr 8, 2026
This was referenced Apr 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Review checklist
Summary by CodeRabbit
New Features
Chores