Skip to content

Fix: in the Web add-on, packets may be incorrectly released in case of errors #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yves57 wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Fix: in the Web add-on, packets may be incorrectly released in case of errors #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f325f5c
Fix: in the Web add-on, packets may be incorrectly released in case o…
Yves57 Jul 2, 2026
3b6dd22
Remove blank line
Yves57 Jul 2, 2026
51e5386
Restore blank line like it was before
Yves57 Jul 2, 2026
b1815cf
Added chunked packet release to the PUT underflow error paths
fdesbiens Jul 28, 2026
a5c4d07
Added a regression test for the PUT Content-Length underflow path
fdesbiens Jul 28, 2026
b40a0e1
Used the lower case (c) in the new test file's copyright line
fdesbiens Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions addons/web/nx_web_http_server.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
*
* SPDX-License-Identifier: MIT
**************************************************************************/
/* Some portions generated by Claude Code (Opus 5). */


/**************************************************************************/
Expand Down Expand Up @@ -4208,8 +4209,11 @@ UINT temp_realm_length = 0;
"NetX HTTP Content Length",
sizeof("NetX HTTP Content Length") - 1, NX_NULL, 0);

/* Release the previous data packet. */
nx_packet_release(data_packet_ptr);
/* Release first chunked packet. */
if (server_ptr -> nx_web_http_server_request_chunked)
{
nx_packet_release(packet_ptr);
}

status = NX_UNDERFLOW;
goto put_process_end;
Expand Down Expand Up @@ -4262,8 +4266,11 @@ UINT temp_realm_length = 0;
"NetX HTTP Content Length",
sizeof("NetX HTTP Content Length") - 1, NX_NULL, 0);

/* Release the previous data packet. */
nx_packet_release(data_packet_ptr);
/* Release first chunked packet. */
if (server_ptr -> nx_web_http_server_request_chunked)
{
nx_packet_release(packet_ptr);
}

status = NX_UNDERFLOW;
goto put_process_end;
Expand Down
1 change: 1 addition & 0 deletions test/cmake/web/regression/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ set(web_test_cases
${SOURCE_DIR}/web_test/netx_web_head_basic_test.c
${SOURCE_DIR}/web_test/netx_web_post_basic_test.c
${SOURCE_DIR}/web_test/netx_web_put_basic_test.c
${SOURCE_DIR}/web_test/netx_web_put_content_length_underflow_test.c
${SOURCE_DIR}/web_test/netx_web_delete_basic_test.c
${SOURCE_DIR}/web_test/netx_web_basic_authenticate_test.c
${SOURCE_DIR}/web_test/netx_web_if_modified_since_test.c
Expand Down
2 changes: 2 additions & 0 deletions test/regression/web_test/netx_https_testcontrol.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ void netx_https_api_test(void*);
void netx_web_basic_test_application_define(void *);
void netx_web_basic_ecc_test_application_define(void *);
void netx_web_put_basic_test_application_define(void *);
void netx_web_put_content_length_underflow_test_application_define(void *);
void netx_web_post_basic_test_application_define(void *);
void netx_web_delete_basic_test_application_define(void *);
void netx_web_head_basic_test_application_define(void *);
Expand Down Expand Up @@ -142,6 +143,7 @@ TEST_ENTRY test_control_tests[] =
{netx_web_response_in_multiple_packets_test_application_define, TEST_TIMEOUT_LOW},
{netx_web_connect_three_times_test_application_define, TEST_TIMEOUT_LOW},
{netx_web_put_basic_test_application_define, TEST_TIMEOUT_LOW},
{netx_web_put_content_length_underflow_test_application_define, TEST_TIMEOUT_LOW},
{netx_web_post_basic_test_application_define, TEST_TIMEOUT_LOW},
{netx_web_head_basic_test_application_define, TEST_TIMEOUT_LOW},
{netx_web_delete_basic_test_application_define, TEST_TIMEOUT_LOW},
Expand Down
Loading