Conversation
|
I'll organize the PR in several commits when it's building. |
a069a72 to
0ff863f
Compare
5474553 to
d3ebf77
Compare
e99017c to
68cf7d3
Compare
|
Here the most impacting changes :
Feel free to squash the commits into one |
91f6a5b to
8d17e5f
Compare
pcdavid
left a comment
There was a problem hiding this comment.
Note that 4.0.5 has just been released: https://spring.io/blog/2026/03/26/spring-boot-4-0-5-available-now
|
|
||
| === Dependency update | ||
|
|
||
| - [releng] Switch to Spring Boot 4.0 |
There was a problem hiding this comment.
Mention the exact version number.
There was a problem hiding this comment.
I'm now using 4.0.0 in the pom.xml
There was a problem hiding this comment.
Any reason not to switch directly to 4.0.5?
There was a problem hiding this comment.
I'll add a commit to switch to 4.0.5 since it should be just a single line to change.
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-liquibase</artifactId> |
There was a problem hiding this comment.
We can't upgrade to liquibase 5.x
There was a problem hiding this comment.
I forced the use of liquibase 4 in dependency management
| package org.eclipse.sirius.web.papaya.representations.table; | ||
|
|
||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import tools.jackson.databind.ObjectMapper; |
There was a problem hiding this comment.
Imports need to be re-ordered
b5c6b1d to
29cfe14
Compare
29cfe14 to
ab91632
Compare
sbegaudeau
left a comment
There was a problem hiding this comment.
This seems good, I've rebased it and handled the conflicts. I'll wait for the build to see the result and merge it if I don't encounter any issue. I'll try to add a couple of minor PRs too and perform a new release soon to open the possibility for downstream projects to switch to Spring Boot 4 too.
aee5a7b to
cb8a8ac
Compare
Bug: #6262 Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
26acc48 to
157f593
Compare
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,difficulty:,type:)CHANGELOG.adocbeen updated to reference the relevant issues?CHANGELOG.adoc? (Including changes in the GraphQL API)CHANGELOG.adoc? For example indoc/screenshots/2022.5.0-my-new-feature.pngArchitectural decision records (ADR)
[doc]?CHANGELOG.adoc?Dependencies
CHANGELOG.adoc?CHANGELOG.adoc?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)useQuery<DATA_TYPE, VARIABLE_TYPE>(…)useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)useState<STATE_TYPE>(…)?.(if the GraphQL API specifies that a field cannot benull, do not treat it has potentiallynullfor example)let diagram: Diagram | null = null;)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request